Repository navigation
[raft] Remove replaces and add nodes with URL - #1906
Merged
Merged
Conversation
the-glu
approved these changes
Nov 4, 2026
Co-authored-by: Maximilien Cuony <the-glu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings modifications to the admin API.
dssctlread the ID from another node (see [raft][admin] Admin API protection #1790).replacesis removed. Replacing a node is parked for a follow-up that uses joint consensus (tracked in [raft] Node replacement should be atomic if implemented #1905). The consequence is that, for now, a node that lost its data cannot rejoin at the same URL in a 3 voter group as removing the old ID would leave fewer than 3 voters (which is rejected). Until replacement is implemented, the node must return using a different URL. This is acceptable for the [raft] MVP release - November 2026 #1741 scope.